Fernet RNG should not return empty string - #745
Open
Deydra71 wants to merge 1 commit into
Open
Conversation
GenerateFernetKey logged RNG failure then returned "". Callers stored that into the Fernet/credential Secret. Change the API to (string, error). On rand.Read failure, return a wrapped error. ensureFernetKeys propagates it so reconcile fails and retries instead of writing bad secrets. Signed-off-by: Veronika Fisarova <vfisarov@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Deydra71 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GenerateFernetKeylogged RNG failure then returned "". Callers stored that into the Fernet/credential Secret. Change the API to (string, error). Onrand.Readfailure, return a wrappederror. ensureFernetKeyspropagates it so reconcile fails and retries instead of writing bad secrets.